2단계 - 사다리 (생성) #2319
Merged
2단계 - 사다리 (생성) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksy90101
reviewed
Apr 6, 2025
ksy90101
requested changes
Apr 6, 2025
ksy90101
reviewed
Apr 6, 2025
ksy90101
reviewed
Apr 6, 2025
- 상수 추가 - isEmpty -> isBlank
- 조건문 통합
- 상수 추가 - 인터페이스 도입
- LadderLine 리스트 반환 메소드 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이번 단계에서는 기존에 적용하던 원칙을 지키는 것과 더불어 Stream 적용에 집중했습니다.
List 를 그대로 반환하는 대신, 리스트의 크기를 반환하는 메소드와 리스트의 인덱스에 해당하는 원소에 접근하는 메소드를 구현하여 IntStream 을 적용했는데요.
리스트를 그대로 반환하는 것에 비해 객체 내부의 필드에 직접 접근하는 것을 막을 수 있었지만 코드의 양 자체는 늘었고 이것이 정말 효율적인지는 좀 더 생각해볼 여지가 있을 거 같습니다.
감사합니다.